Skip to content

Update aiodns requirement from <3.7,>=3.3.0 to >=3.3.0,<4.1#7727

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/pip/aiodns-gte-3.3.0-and-lt-4.1
Open

Update aiodns requirement from <3.7,>=3.3.0 to >=3.3.0,<4.1#7727
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/pip/aiodns-gte-3.3.0-and-lt-4.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 19, 2026 •
edited
Loading

Updates the requirements on aiodns to permit the latest version.

Changelog

Sourced from aiodns's changelog.

4.0.3

  • Restore license metadata that was dropped during the pyproject.toml migration in #244, so packaging tools again detect aiodns as MIT-licensed (#250).

4.0.2

  • Re-release of 4.0.1; the 4.0.1 wheel build failed because the release workflow still invoked python setup.py after #244 removed setup.py, so 4.0.1 never reached PyPI. The release workflow now uses python -m build (#248).

4.0.1

  • Fix Future exception was never retrieved when pycares raises AresError synchronously, e.g. for malformed hostnames (#245, fixes #231)
  • Modernized package setup using pyproject.toml instead of setup.py (#244)
  • Updated dependencies
    • Bumped mypy from 1.19.1 to 2.1.0 (#236, #239, #241, #242)
    • Bumped pytest from 9.0.2 to 9.0.3 (#237)
    • Bumped pytest-cov from 7.0.0 to 7.1.0 (#232)
    • Bumped dependabot/fetch-metadata from 2.4.0 to 3.1.0 (#227, #234, #240)
    • Bumped actions/download-artifact from 7.0.0 to 8.0.1 (#228, #235)
    • Bumped actions/upload-artifact from 6 to 7 (#229)
    • Bumped codecov/codecov-action from 5 to 6 (#233)

4.0.0

  • Breaking change: Requires pycares >= 5.0.0
  • Added new query_dns() method returning native pycares 5.x DNSResult types
  • Deprecated query() method - still works with backward-compatible result types
  • Deprecated gethostbyname() method - use getaddrinfo() instead
  • Added compatibility layer for pycares 4.x result types to ease migration
  • Updated dependencies
    • Bumped pycares from 4.11.0 to 5.0.1 (#220)
    • Bumped pytest from 8.4.2 to 9.0.2 (#224)
    • Bumped pytest-asyncio from 1.2.0 to 1.3.0 (#223)
    • Bumped mypy from 1.19.0 to 1.19.1 (#219)
    • Bumped winloop from 0.3.1 to 0.4.0 (#210)
    • Bumped actions/upload-artifact from 5 to 6 (#222)
    • Bumped actions/download-artifact from 6.0.0 to 7.0.0 (#221)

3.6.1

  • Pin pycares to < 5

3.6.0

  • Fix resolver garbage collection during pending queries (#211)
    • Prevents resolver from being garbage collected while queries are in progress
  • Socket callback optimizations (#172)
    • Improved performance for socket state handling
  • Fixed RTD links (#176)
  • Added Python 3.14 to the CI (#212)
  • Updated dependencies

... (truncated)

Commits

@dependabot dependabot Bot added Dependencies Pull requests that update a dependency file python Pull requests that update python code labels May 19, 2026
@pedro-psb
Copy link
Copy Markdown
Member

pedro-psb commented May 19, 2026

@dependabot rebase

pedro-psb
pedro-psb reviewed May 19, 2026
View reviewed changes
Comment thread pyproject.toml
]
requires-python = ">=3.11"
dependencies = [
"aiodns>=3.3.0,<3.7", # Looks like only bugfixes in z-Stream.
Copy link
Copy Markdown
Member

@pedro-psb pedro-psb May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... This is a major upperbound bump

Copy link
Copy Markdown
Member

@mdellweg mdellweg May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it conflict with pycares which we needed to pin down, because aiodns didn't want to upper bound it?

Copy link
Copy Markdown
Member

@pedro-psb pedro-psb May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pin pycares upperbound to <5 in our CI constraints, and they added a range of >=5, <6 starting in v4.

Copy link
Copy Markdown
Member

@mdellweg mdellweg May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least lesson learned... ;)

Copy link
Copy Markdown
Member

@mdellweg mdellweg May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if dropping it will make the lb install unhappy.

Copy link
Copy Markdown
Member

@mdellweg mdellweg May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaaand........

It does.
What are our options now? Reject all versions of aiodns without a declared upper bound cap on pycares?

Copy link
Copy Markdown
Member

@pedro-psb pedro-psb May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if dropping it will make the lb install unhappy.

I think you meant happy?

Reject all versions of aiodns without a declared upper bound cap on pycares?

I think we can do it. I don't see major risks, but I can be overlooking it

@dependabot
Update aiodns requirement from <3.7,>=3.3.0 to >=3.3.0,<4.1
1b4efc3 
Updates the requirements on [aiodns](https://github.com/aio-libs/aiodns) to permit the latest version.
- [Release notes](https://github.com/aio-libs/aiodns/releases)
- [Changelog](https://github.com/aio-libs/aiodns/blob/master/ChangeLog)
- [Commits](aio-libs/aiodns@v3.3.0...v4.0.3)

---
updated-dependencies:
- dependency-name: aiodns
  dependency-version: 4.0.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/pip/aiodns-gte-3.3.0-and-lt-4.1 branch from 45d7ca2 to 1b4efc3 Compare May 19, 2026 17:04
@mdellweg mdellweg force-pushed the dependabot/pip/aiodns-gte-3.3.0-and-lt-4.1 branch from dfbf76b to 7cbb18b Compare May 21, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedro-psb pedro-psb pedro-psb left review comments

@mdellweg mdellweg mdellweg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Dependencies Pull requests that update a dependency file multi-commit no-changelog no-issue python Pull requests that update python code wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedro-psb @mdellweg